Protect skill not working Topic is solved

When you run into a bug, you can post it here. Yes. -When-.
Please make sure you read the sticky!
renowner
Intermediate Poster
Intermediate Poster
Posts: 58
Joined: Wed Jun 01, 2016 10:09 pm

Protect skill not working

Post by renowner » Sat Jan 26, 2019 2:16 pm

The soldier passive toggle skill "Protect." Isn't working against special moves.
I tested for awhile with another player, as well as taking in feedback from many players who had similar issues in the past.

I had a shield equipped. But sidecut wouldn't ever trigger protect to activate. Though basic attacks did.

How to replicate:
Be a soldier or promoted soldier class.
Have a shield equipped.
Have protect active.
Be next to an ally or summon.

Have an enemy use sidecut against them.
Notice as protect never activates.

User avatar
Neus
Site Admin
Site Admin
Posts: 5345
Joined: Tue Nov 11, 2014 12:53 pm

Re: Protect skill not working

Post by Neus » Sat Feb 02, 2019 8:11 pm

Protect has player debug data associated with it - turn on player debug and test it again, and post what the debug message displays.

User avatar
Spoops
Posted to Death
Posted to Death
Posts: 2582
Joined: Wed Feb 25, 2015 9:25 am
Location: Somewhere

Re: Protect skill not working

Post by Spoops » Sat Feb 02, 2019 10:23 pm

Here's a bunch of protect Data I was able to dig up for you, I tested a majority of skills with Swords/Fists/Bows, I'll also provide if protect worked or not.

(HANGING) - Protect did not work.

Code: Select all

Debug: Checking cost negation effects.
Debug: Before Use Skill called. Strange Redhead, SpOOC, Hanging, 1
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 166.
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
(Basic Attack) - Protect worked

Code: Select all

Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 160.
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 160.
Debug: Before Use Skill called. Strange Redhead, SpOOC, Attack, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 0
Debug: Attack type: /obj/skill/fe_attack
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 160.
Debug: Critical Multiplier for this attack is: 100%
(Sidecut) - Protect did not work.

Code: Select all

Debug: Sidecut - /obj/skill/sk_sidecut
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 158.
Debug: Checking cost negation effects.
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 158.
(Repel) - Protect did not work.

Code: Select all

Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 160.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Strange Redhead, SpOOC, Repel, 1
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 160.
(Shinken) - Protect worked

Code: Select all

Debug: Shinken - /obj/skill/sk_shinken
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 160.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Strange Redhead, SpOOC, Shinken, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 1
Debug: Total Power for Shinken / Chain Blade - Makya was 204.2.
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 163.
Debug: Critical Multiplier for this attack is: 100%
Debug: Checking resistance effects and listing them below for 15 Pierce damage with a bonus of 0% resistance.
(Checkmate) - Protect did not work.

Code: Select all

Debug: Checkmate - /obj/skill/sk_checkmate
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 166.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Strange Redhead, SpOOC, Checkmate, 1
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 166.
(Geldoren) - Protect worked

Code: Select all

Debug: Geldoren - /obj/skill/sk_geldoren
Debug: Total Power for Left Claw / Left Claw was 93.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Strange Redhead, Clawed Cat, Geldoren, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 0
Debug: Geldoren - Weapon Left Claw; 1
Debug: Basic Attack - Weapon Left Claw; 1
Debug: Total Power for Left Claw / Left Claw was 93.
Debug: Critical Multiplier for this attack is: 149.82%
(Ether invite) - Protect worked

Code: Select all

Debug: Before Use Skill called. Strange Redhead, Clawed Cat, Ether Invitation, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 
Debug: Basic Attack - Weapon Left Claw; 1
Debug: Total Power for Left Claw / Left Claw was 106.
Debug: no_reduc was in flags
Debug: magic was in flags
Debug: Checking resistance effects and listing them below for 15 Pierce damage with a bonus of 0% resistance.
(Cutthroat) - Protect did not work.

Code: Select all

Debug: Cutthroat - /obj/skill/cutthroat
Debug: Total Power for Stachel / Stachel was 147.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Strange Redhead, Careless Corbie, Cutthroat, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 
Debug: Basic Attack - Weapon Stachel; 0
Debug: Total Power for Stachel / Stachel was 147.
(Snakeshot) - All Bow skills worked with protect

Code: Select all

Debug: Before Use Skill called. Strange Redhead, Mook Javelineer, Snake Shot, 1
Debug: Protect - Checking Strange Redhead.
Debug: Protect - Checking Tedric.
Debug: Protect - Same party.
Debug: Protect - Is on. 1|0|0 - Valid Use would be 0
(Pulling Shot) - All Bow skills worked with protect

Code: Select all

Debug: Before Use Skill called. Strange Redhead, Mook Javelineer, Pulling Shot, 1
Debug: Protect - Checking Strange Redhead.
Debug: Protect - Checking Tedric.
Debug: Protect - Same party.
Debug: Protect - Is on. 1|0|0 - Valid Use would be 0
(Cripple Leg) - All Bow skills worked with protect

Code: Select all

Debug: Before Use Skill called. Strange Redhead, Mook Javelineer, Cripple Leg, 1
Debug: Protect - Checking Strange Redhead.
Debug: Protect - Checking Tedric.
Debug: Protect - Same party.
Debug: Protect - Is on. 1|0|0 - Valid Use would be 0
(Buster Cannon) - All Bow skills worked with protect

Code: Select all

Debug: Before Use Skill called. Strange Redhead, Mook Javelineer, Buster Cannon, 1
Debug: Protect - Checking Strange Redhead.
Debug: Protect - Checking Tedric.
Debug: Protect - Same party.
Debug: Protect - Is on. 1|0|0 - Valid Use would be 0
Debug:   0
(Blowback Cannon) - All Bow skills worked with protect

Code: Select all

Debug: Before Use Skill called. Strange Redhead, Mook Javelineer, Blowback Cannon, 1
Debug: Protect - Checking Strange Redhead.
Debug: Protect - Checking Tedric.
Debug: Protect - Same party.
Debug: Protect - Is on. 1|0|0 - Valid Use would be 0
Debug:   0

User avatar
Neus
Site Admin
Site Admin
Posts: 5345
Joined: Tue Nov 11, 2014 12:53 pm

Re: Protect skill not working

Post by Neus » Sun Feb 03, 2019 9:12 pm

Well, pretty much all the skills it doesn't work with are the ones that target locations instead of enemies. So I've changed it to where if the protector isn't in the targeted area, but the person they'd protect is, they will swap locations with that target. Some of the others didn't have the proper basic attack flag which has been corrected.

Cutthroat is not a bug; it should only be redirecting attack skills where the protector would be a valid target. Since Cutthroat requires you to be in a specific tile, you can't protect it. Ether Invite should behave similarly if the protector isn't marked by CC.

User avatar
Spoops
Posted to Death
Posted to Death
Posts: 2582
Joined: Wed Feb 25, 2015 9:25 am
Location: Somewhere

Re: Protect skill not working

Post by Spoops » Mon Feb 11, 2019 1:08 am

Skills that work and don't work as of the current update: (2.00.5)

Works (protect blocks):
Hanging
Divine Eyes
Eyes of Elimination
Checkmate
Repel

Doesn't Work (protect does not block):
Couloir
Sillcut
Sidecut
Turnover (Not sure if this one is a bug, thought I'd include it since it was included in our tests)

User avatar
Neus
Site Admin
Site Admin
Posts: 5345
Joined: Tue Nov 11, 2014 12:53 pm

Re: Protect skill not working

Post by Neus » Mon Feb 11, 2019 2:44 am

Post the debug info as well, please.

User avatar
Spoops
Posted to Death
Posted to Death
Posts: 2582
Joined: Wed Feb 25, 2015 9:25 am
Location: Somewhere

Re: Protect skill not working

Post by Spoops » Mon Feb 11, 2019 3:42 am

Certainly, here's what I pulled up

(Basic attack - Protected)

Code: Select all

Debug:   0 
Debug: Attack - /obj/skill/fe_attack
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 142.
Debug: Before Use Skill called. Kaleidoscopic Catastrophe, SpOOC, Stab, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 0
Debug: Attack type: /obj/skill/fe_attack/stab
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 142.
Debug: Checking resistance effects and listing them below for 6.6 Pierce damage with a bonus of 0% resistance.
(Sidecut - Not Protected)

Code: Select all

Debug: Sidecut - /obj/skill/sk_sidecut
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 136.
Debug: Checking cost negation effects.
Debug: Basic Attack - Weapon Chain Blade - Makya; 0
Debug: Total Power for Chain Blade - Makya / Chain Blade - Makya was 136.
Debug: Critical Multiplier for this attack is: 122%
Debug: Hit Rate of 317 VS Dodge Rate of 197


(Sillcut - Not Protected)

Code: Select all

Debug: Sillcut - /obj/skill/sillcut
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: Checking cost negation effects.
Debug: Basic Attack - Weapon Electric Spear - Fulmination; 0
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: Critical Multiplier for this attack is: 170.1%
Debug: Hit Rate of 284 VS Dodge Rate of 197
(Couloir - Not Protected)

Code: Select all

Debug: Couloir - /obj/skill/couloir
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: Tactarg exists  1 
Debug: Tactarg exists  0 
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Kaleidoscopic Catastrophe, Crissi, Couloir, 1
Debug: Basic Attack - Weapon Electric Spear - Fulmination; 0
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: Hit Rate of 271 VS Dodge Rate of 197
(Repel - Protected)

Code: Select all

Debug: Checking cost negation effects.
Debug: Before Use Skill called. Kaleidoscopic Catastrophe, Crissi, Repel, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 1||0||0 - Valid Use would be 0
Debug: Basic Attack - Weapon Electric Spear - Fulmination; 0
Debug: Total Power for Electric Spear - Fulmination / Electric Spear - Fulmination was 93.
Debug: magic was in flags
Debug: Checking resistance effects and listing them below for 12 Pierce damage with a bonus of 0% resistance.
Resist Okay? Yes--------------------------
Ammendum; 0
Pure Fire; 0
Hard Light; 0
Quest Stamps; 0
Golden Glow; 0
Monster Elemental Affinity; 0
Customization Dres; 0
Item el_res() and sayakana; 0
Elemental Weakness Status; 0
Bonus Resistance; 0
Elem Mod Status Effects; 0

Debug: Eviter: Starting check. user=Crissi, atkr=Quiet Armored Man, W=null, S=null
Debug: Eviter:  was not Polearm in valid parry types.
Debug: Eviter:  was not Axe in valid parry types.
Debug: Eviter:  was not Sword in valid parry types.

Post Reply