NEUS Projects
Holy Enchant Bug - Printable Version

+- NEUS Projects (https://neus-projects.net/forums)
+-- Forum: Sigrogana Legend 2 (OOC) (https://neus-projects.net/forums/forumdisplay.php?fid=8)
+--- Forum: Bug Reports (https://neus-projects.net/forums/forumdisplay.php?fid=5)
+--- Thread: Holy Enchant Bug (/showthread.php?tid=3534)

Pages: 1 2

Re: Holy Enchant Bug - Esther - 10-24-2016

Sounds like a balance fix, to me. Can we keep it this way? Delete the meta enchant!

Re: Holy Enchant Bug - Chaos - 10-24-2016

"Esther"' Wrote:Sounds like a balance fix, to me. Can we keep it this way? Delete the meta enchant!

This is a bug report, not a place to argue whether or it not's balanced.

Re: Holy Enchant Bug - Neus - 11-03-2016

I've added a debug message for this in the next version, let me know what it says.

Re: Holy Enchant Bug - Kameron8 - 11-13-2016

Testing this with the new flags. I'm not sure how to read this since it's a direct boolean comparison, but one of the two conditions is throwing false. This is with two holy daggers, hitting a Barghest with Dagger Dance.

Debug: 0
Debug: Attack - /obj/skill/fe_attack
Debug: attack_pow: wep_pw (17) increases Power to 130
Debug: Total Power for Electrified Shank / Electrified Shank was 158.
Debug: Basic Attack - Weapon Electrified Shank; 0
Debug: attack_pow: wep_pw (17) increases Power to 130
Debug: Total Power for Electrified Shank / Electrified Shank was 158.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 0&&1 ( and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shank)
Debug: Dagger Dance: Electrified Shank & Electrified Shiv. Not the same weapon. W1 is_wpntype = 1. W2 is_wpntype = 1
Debug: 1&&1
Debug: Dagger Dance: Electrified Shank & Electrified Shiv. Not the same weapon. W1 is_wpntype = 1. W2 is_wpntype = 1
Debug: Basic Attack - Weapon Electrified Shiv; 0
Debug: attack_pow: wep_pw (17) increases Power to 130
Debug: Total Power for Electrified Shiv / Electrified Shiv was 160.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 0&&1 ( and Electrified Shiv)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shiv)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shiv)

No extra damage is being thrown out. I did the same test against a Jammer, and got essentially the same results.

Debug: 0
Debug: Attack - /obj/skill/fe_attack
Debug: attack_pow: wep_pw (17) increases Power to 130
Debug: Total Power for Electrified Shank / Electrified Shank was 158.
Debug: Basic Attack - Weapon Electrified Shank; 0
Debug: attack_pow: wep_pw (17) increases Power to 130
Debug: Total Power for Electrified Shank / Electrified Shank was 158.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 0&&1 ( and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shank)
Debug: Dagger Dance: Electrified Shank & Electrified Shiv. Not the same weapon. W1 is_wpntype = 1. W2 is_wpntype = 1
Debug: 1&&1
Debug: Dagger Dance: Electrified Shank & Electrified Shiv. Not the same weapon. W1 is_wpntype = 1. W2 is_wpntype = 1
Debug: Basic Attack - Weapon Electrified Shiv; 0
Debug: attack_pow: wep_pw (17) increases Power to 130
Debug: Total Power for Electrified Shiv / Electrified Shiv was 160.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 0&&1 ( and Electrified Shiv)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shiv)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 0&&1 ( and Electrified Shiv)

If I had to throw out a guess based on how identical they are, there's an issue with determining whether the target is possessed/undead?

Re: Holy Enchant Bug - Kameron8 - 11-20-2016

Bump.

Re: Holy Enchant Bug - Neus - 11-20-2016

I made another small adjustment, please retest in the next version.

Re: Holy Enchant Bug - Kameron8 - 11-21-2016

No damage increase, still. Here's the logs of hitting a Specter and then a Jammer. All the possession checks are true, but I assume they're for the weapon.

Battle Log (first Holy attack, then a non-holy attack):

Critical Hit! Hirota Nobuhisa attacks Spectre with Holy Weapon and hits them!
Spectre takes 306 Pierce physical damage.
Spectre takes 20 Lightning magical damage.
Spectre takes 19 Wind magical damage.
Hirota Nobuhisa's turn.
Critical Hit! Hirota Nobuhisa attacks Spectre with Slightly Less Powerful Non Holy Weapon and hits them!
Spectre takes 283 Pierce physical damage.
Spectre's turn.

Specter
Holy:

Debug: 0
Debug: Sub-Attack - /obj/skill/fe_sub_attack
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 146.
Debug: Basic Attack - Weapon Electrified Shank; 0
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 146.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)

Non Holy:

Debug: 0
Debug: Attack - /obj/skill/fe_attack
Debug: attack_pow: wep_pw (19) increases Power to 122
Debug: Total Power for Kritzkrieg / Kritzkrieg was 134.
Debug: Basic Attack - Weapon Kritzkrieg; 0
Debug: attack_pow: wep_pw (19) increases Power to 122
Debug: Total Power for Kritzkrieg / Kritzkrieg was 134.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 0&&1 (Kritzkrieg and Kritzkrieg)
Debug: 0&&1

Jammer
Holy:

Debug: 0
Debug: Sub-Attack - /obj/skill/fe_sub_attack
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 156.
Debug: Basic Attack - Weapon Electrified Shank; 0
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 156.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Maintenance Information: new_maint_self, am 5, max 75
Debug: Maintenance Information: newtal_maint_apply, am 5, max 75, Kritzkrieg, Electrified Shank
Debug: Maintenance Information: newtal_maint_apply, max_dura 30, res 1
Debug: Maintenance Information: newtal_maint_apply, max_dura 30, res 2


Re: Holy Enchant Bug - Neus - 11-21-2016

Okay, one last debug message added. We're getting closer.

Re: Holy Enchant Bug - Kameron8 - 11-22-2016

I'm assuming you know this already, but I'll throw it out there just in case. No damage increase from holy with these additions.

New debug logs:

Specter:

Holy Weapon

Debug: 0
Debug: Attack - /obj/skill/fe_attack
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 150.
Debug: Basic Attack - Weapon Electrified Shank; 0
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 150.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Possessed Check: 0||0||1||0
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Possessed Check: 0||0||1||0
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Possessed Check: 0||0||1||0
Debug: 0&&1

Non-Holy Weapon
Debug: 0
Debug: Sub-Attack - /obj/skill/fe_sub_attack
Debug: attack_pow: wep_pw (16) increases Power to 116
Debug: Total Power for Kritler / Kritler was 132.
Debug: Basic Attack - Weapon Kritler; 0
Debug: attack_pow: wep_pw (16) increases Power to 116
Debug: Total Power for Kritler / Kritler was 132.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 0&&1 (Kritler and Kritler)

Jammer:
Debug: 0
Debug: Attack - /obj/skill/fe_attack
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 156.
Debug: Basic Attack - Weapon Electrified Shank; 0
Debug: attack_pow: wep_pw (17) increases Power to 132
Debug: Total Power for Electrified Shank / Electrified Shank was 156.
Debug: Critical Multiplier for this attack is: 206.38%
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Possessed Check: 0||0||0||0
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Possessed Check: 0||0||0||0
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Possessed Check: 1&&1 (Electrified Shank and Electrified Shank)
Debug: Possessed Check: 0||0||0||0
Debug: 0&&1


Re: Holy Enchant Bug - Neus - 11-30-2016

This should be corrected in 1.68c.