NEUS Projects
[V. 2.49] One-Hit Wonder not applying to Casting Tools. - Printable Version

+- NEUS Projects (https://neus-projects.net/forums)
+-- Forum: Sigrogana Legend 2 (OOC) (https://neus-projects.net/forums/forumdisplay.php?fid=8)
+--- Forum: Bug Reports (https://neus-projects.net/forums/forumdisplay.php?fid=5)
+--- Thread: [V. 2.49] One-Hit Wonder not applying to Casting Tools. (/showthread.php?tid=8286)



[V. 2.49] One-Hit Wonder not applying to Casting Tools. - Joseph Jostar - 08-24-2021

The Magic Gunner skill 'One-Hit Wonder' is described as increasing Power for shotgun-type weapons by +25 at Rank 5. Testing seems to show that this increase in power does not apply to spells when a shotgun is used as a casting tool (such as Magical Nova, or via the conduiz material). The increase in power is also not reflected in a weapon's examine menu, though it seems to apply as normal to basic attacks and skills such as lead storm.

Weapon Used
[Image: 53fac17a188d46aaabc015435a3189e2.png]

- Without One-Hit Wonder
Basic Attack
System: Debug: Total Power for Magical Nova / Magical Nova was 42.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack/gun. attack_nums: 1
System: Debug: Total Power for Magical Nova / Magical Nova was 42.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown attacks Prinny with Magical Nova!
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 42 Pierce physical damage.
System: * Initial Damage: 42 Pierce Physical, flags: projectile, sk: null, wep: Magical Nova / /obj/items/equip/weapon/guns/magical_nova * play_atk_anim was 1. * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 32 Critical VS 0 Critical Evade. (42) * armor was allowed. armor_reduc was 0. (42) * spec_flat_reduc was 0. (42) * amp_multi was 1. (42) * reduc_multi was 100. (42); MAG DEF, 0 PHYS DEF, 100 REDUC * elem_reduc was 0. (42) * Damage caps applied. (42) * Damage shields applied. (42) * Final damage was: 42.
System: * basic_attack(atk:Ren Brown,defTonguerinny,W:Magical Nova,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 0. * crit_multi was 114. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&2
Sear [Rank 5]
System: Debug: Checking cost negation effects.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown used ;action=/obj/skill/spell/sear;function=tac_desc]Sear.
System: Debug: Magical Nova was the casting tool.
System: Debug: Total Power for Sear / was 56.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 56 Fire magical damage. (Sear / Magical Nova)
System: * Initial Damage: 56 Fire Magic, flags: magic, sk: Sear (/obj/skill/spell/sear) , wep: Magical Nova / /obj/items/equip/weapon/guns/magical_nova * play_atk_anim was . * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: Defender was critical immune or crit_multi was 0. (56) * armor was allowed. armor_reduc was 0. (56) * spec_flat_reduc was 0. (56) * amp_multi was 1. (56) * reduc_multi was 100. (56); 0 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 0. (56) * Damage caps applied. (56) * Damage shields applied. (56) * Final damage was: 56.
Nova Eraser
System: Debug: Checking cost negation effects.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown used ;action=/obj/skill/spell/nova_eraser;function=tac_desc]Nova Eraser.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Nova Eraser, 1
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 126 Light magical damage. (Nova Eraser / Magical Nova)
System: * Initial Damage: 126 Light Magic, flags: magic, no_evasion, sk: Nova Eraser (/obj/skill/spell/nova_eraser) , wep: Magical Nova / /obj/items/equip/weapon/guns/magical_nova * play_atk_anim was . * Critical check: Defender was critical immune or crit_multi was 0. (126) * armor was allowed. armor_reduc was 0. (126) * spec_flat_reduc was 0. (126) * amp_multi was 1. (126) * reduc_multi was 100. (126); 0 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 0. (126) * Damage caps applied. (126) * Damage shields applied. (126) * Final damage was: 126.

- With One-Hit Wonder
Basic Attack
System: Debug: Total Power for Magical Nova / Magical Nova was 67.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack/gun. attack_nums: 1
System: Debug: Total Power for Magical Nova / Magical Nova was 67.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown attacks Prinny with Magical Nova!
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 67 Pierce physical damage.
System: * Initial Damage: 67 Pierce Physical, flags: projectile, sk: null, wep: Magical Nova / /obj/items/equip/weapon/guns/magical_nova * play_atk_anim was 1. * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 32 Critical VS 0 Critical Evade. (67) * armor was allowed. armor_reduc was 0. (67) * spec_flat_reduc was 0. (67) * amp_multi was 1. (67) * reduc_multi was 100. (67); MAG DEF, 0 PHYS DEF, 100 REDUC * elem_reduc was 0. (67) * Damage caps applied. (67) * Damage shields applied. (67) * Final damage was: 67.
System: * basic_attack(atk:Ren Brown,defTonguerinny,W:Magical Nova,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 0. * crit_multi was 114. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&2
Sear [Rank 5]
System: Debug: Checking cost negation effects.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown used ;action=/obj/skill/spell/sear;function=tac_desc]Sear.
System: Debug: Magical Nova was the casting tool.
System: Debug: Total Power for Sear / was 56.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 56 Fire magical damage. (Sear / Magical Nova)
System: * Initial Damage: 56 Fire Magic, flags: magic, sk: Sear (/obj/skill/spell/sear) , wep: Magical Nova / /obj/items/equip/weapon/guns/magical_nova * play_atk_anim was . * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: Defender was critical immune or crit_multi was 0. (56) * armor was allowed. armor_reduc was 0. (56) * spec_flat_reduc was 0. (56) * amp_multi was 1. (56) * reduc_multi was 100. (56); 0 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 0. (56) * Damage caps applied. (56) * Damage shields applied. (56) * Final damage was: 56.
Nova Eraser
System: Debug: Checking cost negation effects.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown used ;action=/obj/skill/spell/nova_eraser;function=tac_desc]Nova Eraser.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Nova Eraser, 1
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 126 Light magical damage. (Nova Eraser / Magical Nova)
System: * Initial Damage: 126 Light Magic, flags: magic, no_evasion, sk: Nova Eraser (/obj/skill/spell/nova_eraser) , wep: Magical Nova / /obj/items/equip/weapon/guns/magical_nova * play_atk_anim was . * Critical check: Defender was critical immune or crit_multi was 0. (126) * armor was allowed. armor_reduc was 0. (126) * spec_flat_reduc was 0. (126) * amp_multi was 1. (126) * reduc_multi was 100. (126); 0 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 0. (126) * Damage caps applied. (126) * Damage shields applied. (126) * Final damage was: 126.


This was also tested with a normal shotgun using Conduiz as the material to cast nature spells.

Weapon Used
[Image: d6af8eca9aea2d0965f98445136156fc.png]

- Without One-Hit Wonder
Basic Attack
System: Debug: Total Power for Shotgun / Shotgun was 44.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack/gun. attack_nums: 1
System: Debug: Total Power for Shotgun / Shotgun was 44.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown attacks Prinny with Shotgun!
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 44 Pierce physical damage.
System: * Initial Damage: 44 Pierce Physical, flags: projectile, sk: null, wep: Shotgun / /obj/items/equip/weapon/guns/shotgun * play_atk_anim was 1. * 0 Evade VS 190 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 35 Critical VS 0 Critical Evade. (44) * armor was allowed. armor_reduc was 0. (44) * spec_flat_reduc was 0. (44) * amp_multi was 1. (44) * reduc_multi was 100. (44); MAG DEF, 0 PHYS DEF, 100 REDUC * elem_reduc was 0. (44) * Damage caps applied. (44) * Damage shields applied. (44) * Final damage was: 44.
System: * basic_attack(atk:Ren Brown,defTonguerinny,W:Shotgun,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 0. * crit_multi was 114. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&1
Ryemei [Rank 5]
System: Debug: Checking cost negation effects.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown used ;action=/obj/skill/spell/ryemei;function=tac_desc]Ryemei.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Ryemei, 1
System: Debug: Shotgun was the casting tool.
System: Debug: Total Power for Ryemei / was 60.6.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 60 Lightning magical damage. (Ryemei / Shotgun)
System: * Initial Damage: 60.6 Lightning Magic, flags: magic, projectile, sk: Ryemei (/obj/skill/spell/ryemei) , wep: Shotgun / /obj/items/equip/weapon/guns/shotgun * play_atk_anim was . * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: Defender was critical immune or crit_multi was 0. (60.6) * armor was allowed. armor_reduc was 0. (60.6) * spec_flat_reduc was 0. (60.6) * amp_multi was 1. (60.6) * reduc_multi was 100. (60.6); 0 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 0. (60.6) * Damage caps applied. (60.6) * Damage shields applied. (60.6) * Final damage was: 60.

- With One-Hit Wonder
Basic Attack
System: Debug: Total Power for Shotgun / Shotgun was 69.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack/gun. attack_nums: 1
System: Debug: Total Power for Shotgun / Shotgun was 69.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown attacks Prinny with Shotgun!
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 69 Pierce physical damage.
System: * Initial Damage: 69 Pierce Physical, flags: projectile, sk: null, wep: Shotgun / /obj/items/equip/weapon/guns/shotgun * play_atk_anim was 1. * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 35 Critical VS 0 Critical Evade. (69) * armor was allowed. armor_reduc was 0. (69) * spec_flat_reduc was 0. (69) * amp_multi was 1. (69) * reduc_multi was 100. (69); MAG DEF, 0 PHYS DEF, 100 REDUC * elem_reduc was 0. (69) * Damage caps applied. (69) * Damage shields applied. (69) * Final damage was: 69.
System: * basic_attack(atk:Ren Brown,defTonguerinny,W:Shotgun,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 0. * crit_multi was 114. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&2
Ryemei [Rank 5]
System: Debug: Checking cost negation effects.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Ren Brown used ;action=/obj/skill/spell/ryemei;function=tac_desc]Ryemei.
System: Debug: Before Use Skill called. Prinny, Ren Brown, Ryemei, 1
System: Debug: Shotgun was the casting tool.
System: Debug: Total Power for Ryemei / was 60.6.
[img]file:///C:/Users/Justi/Documents/BYOND/cache/tmp14456/battle_msg.png[/img] Prinny takes 60 Lightning magical damage. (Ryemei / Shotgun)
System: * Initial Damage: 60.6 Lightning Magic, flags: magic, projectile, sk: Ryemei (/obj/skill/spell/ryemei) , wep: Shotgun / /obj/items/equip/weapon/guns/shotgun * play_atk_anim was . * 0 Evade VS 184 Hit. *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: Defender was critical immune or crit_multi was 0. (60.6) * armor was allowed. armor_reduc was 0. (60.6) * spec_flat_reduc was 0. (60.6) * amp_multi was 1. (60.6) * reduc_multi was 100. (60.6); 0 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 0. (60.6) * Damage caps applied. (60.6) * Damage shields applied. (60.6) * Final damage was: 60.



RE: [V. 2.49] One-Hit Wonder not applying to Casting Tools. - Senna - 08-27-2021

The power affects basic attack only, friend.


RE: [V. 2.49] One-Hit Wonder not applying to Casting Tools. - Joseph Jostar - 08-28-2021

(08-27-2021, 08:59 PM)Senna Wrote: The power affects basic attack only, friend.

That is the inconsistency between the skill as described and the way it functions, yes, thank you.


RE: [V. 2.49] One-Hit Wonder not applying to Casting Tools. - Neus - 08-30-2021

This should be corrected.