[Lolzytripd]

si

[Neus]

Any debug information for basic attacks? I added some additional debug info for skills in 1.89d, so recheck it once that's up.

[Shujin]

Some samples of the debug text from serval skills.

Basic AttackIs protected)

Debug: Total Power for Fenrir / Fenrir was 101.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Attack, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 0||1||0 - Valid Use would be 1
Debug: Basic Attack - Weapon Fenrir; 0
Debug: Total Power for Fenrir / Fenrir was 101.
Debug: no_armor was in flags
Debug: magic was in flags
Debug: 0&&1
Debug: 0

Wazabanenot protected)

Debug: Wazabane - /obj/skill/wazabane
Debug: Total Power for Fenrir / Fenrir was 99.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Wazabane, 1
Debug: Basic Attack - Weapon Fenrir; 0
Debug: Total Power for Fenrir / Fenrir was 99.
Debug: Critical Multiplier for this attack is: 130%
Debug: no_armor was in flags
Debug: magic was in flags

Laudela: (Protected)

Debug: Total Power for Fenrir / Fenrir was 99.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, L'au-Dela, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 0||1||0 - Valid Use would be 1
Debug: Basic Attack - Weapon Fenrir; 0
Debug: Total Power for Fenrir / Fenrir was 99.
Debug: Critical Multiplier for this attack is: 130%
Debug: no_armor was in flags
Debug: magic was in flags

Power Gradiation: (Not Protected)

Debug: 0
Debug: Power Gradation - /obj/skill/power_gradation
Debug: Total Power for Fenrir / Fenrir was 97.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Power Gradation, 1
Debug: Basic Attack - Weapon Fenrir; 0
Debug: Total Power for Fenrir / Fenrir was 97.
Debug: Critical Multiplier for this attack is: 130%
Debug: magic was in flags
Debug: no_armor was in flags
Debug: magic was in flags

GeldorenProtected)

Debug: Total Power for Weight / Weight was 91.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Geldoren, 1
Debug: Protect - Same party.
Debug: Protect - Is on. 0||1||0 - Valid Use would be 1
Debug: Geldoren - Weapon Weight; 1
Debug: Basic Attack - Weapon Weight; 1
Debug: Total Power for Weight / Weight was 91.
Debug: Critical Multiplier for this attack is: 125%
Debug: no_armor was in flags
Debug: magic was in flags

Incise: (not protected)

Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Incise, 1
Debug: Total Power for Incise / Fenrir was 36.5.
Debug: Hit Rate of 286 VS Dodge Rate of 76
Debug: Trying status /obj/status/celsius
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

Shinken basic attackand projectile: ( Both Not protected)

Debug: Total Power for Fenrir / Fenrir was 73.
Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Shinken, 1
Debug: Basic Attack - Weapon Fenrir; 0
Debug: Total Power for Fenrir / Fenrir was 73.
Debug: no_armor was in flags
Debug: magic was in flags
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

Projectile
Debug: Checking cost negation effects.
Debug: Total Power for Shinken / Fenrir was 75.
Debug: Hit Rate of 276 VS Dodge Rate of 76
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

Chaser: (notprotected)

Debug: Checking cost negation effects.
Debug: Chaser dir is 2
Debug: Total Power for Chaser / Fenrir was 65.7.
Debug: Hit Rate of 293 VS Dodge Rate of 76
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

Elemental Rave: (not protected)

Debug: Checking cost negation effects.
Debug: Before Use Skill called. Icy Scientist, Shivania van Fenrir, Elemental Rave, 1
Debug: Total Power for Elemental Rave / Fenrir was 65.7.
Debug: no_reduc was in flags
Debug: Hit Rate of 295 VS Dodge Rate of 76
Debug: no_reduc was in flags
Debug: Hit Rate of 296 VS Dodge Rate of 76
Debug: no_reduc was in flags
Debug: Hit Rate of 296 VS Dodge Rate of 76
Debug: no_reduc was in flags
Debug: Hit Rate of 297 VS Dodge Rate of 76
Debug: no_reduc was in flags
Debug: Hit Rate of 298 VS Dodge Rate of 76
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

Rising Tide (not protected)

Debug: Checking cost negation effects.
Debug: Total Power for Rising Tide / Fenrir was 73.
Debug: Hit Rate of 298 VS Dodge Rate of 76
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

Retreating swipe (Not potected, both Targeted)

Debug: Checking cost negation effects.
Debug: Steps was 1
Debug: Total Power for Retreating Swipe / Fenrir was 73.
Debug: Hit Rate of 300 VS Dodge Rate of 76
Debug: Total Power for Retreating Swipe / Fenrir was 73.
Debug: Hit Rate of 274 VS Dodge Rate of 51
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker
Debug: Incise Can Select: 0 Martial Lawbreaker

[Lolzytripd]

funny enough the only time I see protect "work" is when its a charmed enemy.

[adamkad1]

Shine knights still do not protec

[Neus]

Thing with this skill is, it's only supposed to protect you from basic attacks or skills that function as basic attacks. A few of these didn't have the 'acts as basic' flag and have been corrected, but if they're autohits, then this is normal.

[Shujin]

Didn't you change it back then that stuff like Chaser, Kagekiri and other autohitstuff ARE supposed to be protected?

Cause honestly, that would make Protect so much more worth it to get to play the bodyguard type of person.


Also as a sidenote: Is it supposed to deal full damage on both protectors in case you have two? (or even three.)

Doesn't feel like that should be the case.

[Neus]

I think it was only changed to take all of the effects of the skills that use basic attacks, since before if it did something else in addition to a basic attack, you'd take the basic but the rest of the effects would get put on the original target.

[Autumn]

The original change was to make it so that pulling shot wouldn't pull the target you were supposed to be protecting, you also said that protecting autohits might be a side effect of the change.

I'm fine with it only working on basics as long as I can provide a good amount of redirection for dodgy characters eating shit to hit stacking.