[Senna]

It seems flipshot (Not sure if Retreat Shot is also affected by it) isn't providing the bonus hit unless this does not show in debug.

Code:

System: Debug: attack_pow: spec_arrow_dmg_bonus increases Power to 29
System: Debug: Total Power for Bow / Bow was 32.
System: Debug: Before Use Skill called. Prinny, CattoZerg, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack/bow. attack_nums:
System: Debug: attack_pow: spec_arrow_dmg_bonus increases Power to 29
System: Debug: Total Power for Bow / Bow was 32.
CattoZerg attacks Prinny with Bow!
Critical Hit! Prinny takes 49 Pierce physical damage.
System: Debug: Rolling wound: /wound/open_wound/stab with a chance of 3.45%
System:
* Initial Damage: 32 Pierce Physical, flags: projectile, sk: null, wep: Bow / /obj/items/equip/weapon/ranged/bows/bow
* play_atk_anim was 1.
* 0 Evade VS 207 Hit.
*2 Roll(s) Remaining. This one was a hit.
*1 Roll(s) Remaining. This one was a hit.
* Critical check: 77 Critical VS 0 Critical Evade. (32)
* Critical hit multi was 155. (49.6)
* armor was allowed. armor_reduc was 0. (49.6)
* spec_flat_reduc was 0. (49.6)
* amp_multi was 1. (49.6)
* reduc_multi was 100. (49.6);  MAG DEF, 0 PHYS DEF, 100 REDUC
* elem_reduc was 0. (49.6)
* Damage caps applied. (49.6)
* Damage shields applied. (49.6)
* Final damage was: 49.
CattoZerg recovered 2 FP.
System: * basic_attack(atk:CattoZerg,def:Prinny,W:Bow,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1)
* atk_multi was 100. atk_bonus was 0. dmg_scale was 0.
* crit_multi was 155. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&2
System: Secondary targetting required. Select Target 1 > Select Target 2 > Skill Used. Press accept/cancel to move forward/backward in this process.
System: Secondary aiming now: on.
System: Debug: Checking cost negation effects.
System: Debug: attack_pow: spec_arrow_dmg_bonus increases Power to 29
System: Debug: Total Power for Bow / Bow was 32.
CattoZerg attacks Prinny with Bow!
Critical Hit! Prinny takes 49 Pierce physical damage.
System: Debug: Rolling wound: /wound/open_wound/stab with a chance of 3.45%
System:
* Initial Damage: 32 Pierce Physical, flags: projectile, sk: null, wep: Bow / /obj/items/equip/weapon/ranged/bows/bow
* play_atk_anim was 1.
* 0 Evade VS 207 Hit.
*2 Roll(s) Remaining. This one was a hit.
*1 Roll(s) Remaining. This one was a hit.
* Critical check: 77 Critical VS 0 Critical Evade. (32)
* Critical hit multi was 155. (49.6)
* armor was allowed. armor_reduc was 0. (49.6)
* spec_flat_reduc was 0. (49.6)
* amp_multi was 1. (49.6)
* reduc_multi was 100. (49.6);  MAG DEF, 0 PHYS DEF, 100 REDUC
* elem_reduc was 0. (49.6)
* Damage caps applied. (49.6)
* Damage shields applied. (49.6)
* Final damage was: 49.
CattoZerg recovered 2 FP.
System: * basic_attack(atk:CattoZerg,def:Prinny,W:Bow,dmg_mod:0,hit_mod:15,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1)
* atk_multi was 100. atk_bonus was 0. dmg_scale was 0.
* crit_multi was 155. crit_dmg_flat was 0. attack_num was 1.

[Neus]

As far as I can tell, it is applying, hence why it says hit_mod:15.

[InsainArcaneBirdbrain]

I tested this again with a vanilla, unupgraded 1*bow at 3 range in the front. While I do have the other ranger passives here, I should be nowhere near the hit cap and yet both the standard basic and flip shot had the same end total hit according to log. (First hit is normal basic, second is flip shot).

I saw the hit mod in the log at the correct value, but the chance isn't getting represented in the hit vs eva part. If that's how it supposed to be, uh, then my apologies.


System: Debug: attack_pow: spec_arrow_dmg_bonus increases Power to 29
System: Debug: Total Power for Bow / Bow was 32.
System: Debug: Before Use Skill called. Prinny, CattoZerg, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack/bow. attack_nums:
System: Debug: attack_pow: spec_arrow_dmg_bonus increases Power to 29
System: Debug: Total Power for Bow / Bow was 32.
CattoZerg attacks Prinny with Bow!
Critical Hit! Prinny takes 49 Pierce physical damage.
System: Debug: Rolling wound: /wound/open_wound/stab with a chance of 3.45%
System:
* Initial Damage: 32 Pierce Physical, flags: projectile, sk: null, wep: Bow / /obj/items/equip/weapon/ranged/bows/bow
* play_atk_anim was 1.
* 0 Evade VS 208 Hit.
*2 Roll(s) Remaining. This one was a hit.
*1 Roll(s) Remaining. This one was a hit.
* Critical check: 82 Critical VS 0 Critical Evade. (32)
* Critical hit multi was 155. (49.6)
* armor was allowed. armor_reduc was 0. (49.6)
* spec_flat_reduc was 0. (49.6)
* amp_multi was 1. (49.6)
* reduc_multi was 100. (49.6);  MAG DEF, 0 PHYS DEF, 100 REDUC
* elem_reduc was 0. (49.6)
* Damage caps applied. (49.6)
* Damage shields applied. (49.6)
* Final damage was: 49.
CattoZerg recovered 2 FP.
System: * basic_attack(atk:CattoZerg,defrinny,W:Bow,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1)
* atk_multi was 100. atk_bonus was 0. dmg_scale was 0.
* crit_multi was 155. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&3
System: Secondary targetting required. Select Target 1 > Select Target 2 > Skill Used. Press accept/cancel to move forward/backward in this process.
System: Secondary aiming now: on.
System: Debug: Checking cost negation effects.
System: Debug: attack_pow: spec_arrow_dmg_bonus increases Power to 29
System: Debug: Total Power for Bow / Bow was 32.
CattoZerg attacks Prinny with Bow!
Critical Hit! Prinny takes 49 Pierce physical damage.
System: Debug: Rolling wound: /wound/open_wound/stab with a chance of 3.45%
System:
* Initial Damage: 32 Pierce Physical, flags: projectile, sk: null, wep: Bow / /obj/items/equip/weapon/ranged/bows/bow
* play_atk_anim was 1.
* 0 Evade VS 208 Hit.
*2 Roll(s) Remaining. This one was a hit.
*1 Roll(s) Remaining. This one was a hit.
* Critical check: 82 Critical VS 0 Critical Evade. (32)
* Critical hit multi was 155. (49.6)
* armor was allowed. armor_reduc was 0. (49.6)
* spec_flat_reduc was 0. (49.6)
* amp_multi was 1. (49.6)
* reduc_multi was 100. (49.6);  MAG DEF, 0 PHYS DEF, 100 REDUC
* elem_reduc was 0. (49.6)
* Damage caps applied. (49.6)
* Damage shields applied. (49.6)
* Final damage was: 49.
CattoZerg recovered 2 FP.
System: * basic_attack(atk:CattoZerg,defrinny,W:Bow,dmg_mod:0,hit_mod:15,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1)
* atk_multi was 100. atk_bonus was 0. dmg_scale was 0.
* crit_multi was 155. crit_dmg_flat was 0. attack_num was 1.

[Neus]

I'll have to ask you to check after the next update, because it's possible the bug was already fixed. Testing this offline gives the proper hit results.

[InsainArcaneBirdbrain]

Just tested again on V2.5, and all seems good now!