10-03-2021, 03:24 AM
Good luck with this one, Dev. This is beyond me.
As of right now, Desperado Striker just... doesn't work. Attacking an enemy with exactly one durability remaining does... nothing. The attack seems to function as normal.
The weapon used for the tests was a Parasitic Fellgrant Drinker.
On top of this, when starting battle with a broken weapon (and sometimes without one), the parasitic enchantment only restores 0.1 durability instead of the intended 1 durability.
Not sure how any of this happened, but I've included images (and text!) of the debug I got.
Note that the 'get_all_actions_new' occurred after every attack and at the start of every turn.
(Debug text)
As of right now, Desperado Striker just... doesn't work. Attacking an enemy with exactly one durability remaining does... nothing. The attack seems to function as normal.
The weapon used for the tests was a Parasitic Fellgrant Drinker.
On top of this, when starting battle with a broken weapon (and sometimes without one), the parasitic enchantment only restores 0.1 durability instead of the intended 1 durability.
Not sure how any of this happened, but I've included images (and text!) of the debug I got.
Note that the 'get_all_actions_new' occurred after every attack and at the start of every turn.
(Debug text)
System: Debug: Movement: In a battle and no tactarg or tac_move.
System: Debug: Total Power for Doomed Spear / Doomed Spear was 176.5.
System: Debug: Before Use Skill called. Grave Digger, Doomed Spear, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack. attack_nums:
System: Debug: Total Power for Doomed Spear / Doomed Spear was 176.5.
Doomed Spear attacks Grave Digger with Doomed Spear!
Eviter! But Grave Digger parries the attack!
Grave Digger takes 40 Pierce physical damage.
System: * Initial Damage: 177.5 Pierce Physical, flags: , sk: null, wep: Doomed Spear / /obj/items/equip/weapon/spears/fellgrant_drinker * play_atk_anim was 1. * 43 Evade VS 231 Hit. (Damage Hit Mod was 0) *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 64 Critical VS 49 Critical Evade. (177.5) * spec_flat_reduc was 0. (177.5) * amp_multi was 1.05. (186.375) * reduc_multi was 25.1247. (46.8261); MAG DEF, 47.106 PHYS DEF, 95 REDUC * elem_reduc was 10. (42.1435) * armor was allowed. armor_reduc was 2. (40.1435) * Damage caps applied. (40.1435) * Damage shields applied. (40.1435) * Final damage was: 40.
Grave Digger attacks Doomed Spear with Shovel!
System: Debug: Mercalan Mist Bonus Evade: 0
System: Debug: Eviter: Starting check. user=Doomed Spear, atkr=Grave Digger, W=Shovel, S=null
System: Debug: Eviter: Chance of 26 was not successful.
Critical Hit! Doomed Spear takes 39 Pierce physical damage.
Status Infliction: 150.72 VS Status Resistance: 27
Doomed Spear was inflicted with Status Resistance Lowered!
System: * Initial Damage: 55.75 Pierce Physical, flags: counter, sk: null, wep: Shovel / /obj/items/equip/weapon/spears/deadly_smile * play_atk_anim was 1. * 11 Evade VS 229 Hit. (Damage Hit Mod was 0) *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 88 Critical VS 30 Critical Evade. (55.75) * Critical hit multi was 135. (75.2625) * spec_flat_reduc was 0. (75.2625) * amp_multi was 1.05. (79.0256) * reduc_multi was 83.885. (66.2906); MAG DEF, 11.7 PHYS DEF, 95 REDUC * elem_reduc was 0. (66.2906) * armor was allowed. armor_reduc was 27. (39.2906) * Damage caps applied. (39.2906) * Damage shields applied. (39.2906) * Final damage was: 39.
Grave Digger recovered 2 FP.
System: * basic_attack(atk:Grave Digger,def:Doomed Spear,W:Shovel,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:50,counter:1,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 50. * crit_multi was 135. crit_dmg_flat was 0. attack_num was 1.
Doomed Spear recovered 1 FP.
Doomed Spear recovered 5 FP.
Doomed Spear recovered 9 HP.
System: * basic_attack(atk:Doomed Spear,def:Grave Digger,W:Doomed Spear,dmg_mod:1,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 0. * crit_multi was 157. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&1
System: Debug: get_all_actions_new: list was this - Movement (/obj/skill/move), Attack (/obj/skill/fe_attack), Multifront (/obj/skill/fe_attack/multifront), Capture (/obj/skill/capture), War Cry (/obj/skill/war_cry), Couloir (/obj/skill/couloir), Sillcut (/obj/skill/sillcut), Lance de Lion (/obj/skill/lance_de_lion), Cyclone Spear (/obj/skill/cyclone_spear), Falcon Strike (/obj/skill/falcon_strike), Rebound (/obj/skill/sk_rebound), Ether Invitation (/obj/skill/sk_ether_invite), Haunting (/obj/skill/sk_haunting), Gravestone (/obj/skill/gravestone), Painproof (/obj/skill/painproof), Burn Away (/obj/skill/burn_away), Dive Down (/obj/skill/dive_down), Lift Off (/obj/skill/spell/lift_off), Eviter (/obj/skill/toggle/eviter), (null), Guard (/obj/skill/fe_guard), Golden Eyes (/obj/skill/passive/racial/golden_eyes), Instinct (Lupine) (/obj/skill/passive/racial/instinct), Kick (/obj/skill/kick), Skip (/obj/skill/skip), Limit Potential (/obj/skill/toggle/limit_potential), Flee (/obj/skill/flee), End Turn (/obj/skill/end_turn), Leave Battle (/obj/skill/leave_battle)
Grave Digger's turn.
System: Debug: get_all_actions_new: list was this - Movement (/obj/skill/move), Attack (/obj/skill/fe_attack), Multifront (/obj/skill/fe_attack/multifront), Capture (/obj/skill/capture), War Cry (/obj/skill/war_cry), Couloir (/obj/skill/couloir), Sillcut (/obj/skill/sillcut), Lance de Lion (/obj/skill/lance_de_lion), Cyclone Spear (/obj/skill/cyclone_spear), Falcon Strike (/obj/skill/falcon_strike), Rebound (/obj/skill/sk_rebound), Ether Invitation (/obj/skill/sk_ether_invite), Haunting (/obj/skill/sk_haunting), Gravestone (/obj/skill/gravestone), Painproof (/obj/skill/painproof), Burn Away (/obj/skill/burn_away), Dive Down (/obj/skill/dive_down), Lift Off (/obj/skill/spell/lift_off), Eviter (/obj/skill/toggle/eviter), (null), Guard (/obj/skill/fe_guard), Golden Eyes (/obj/skill/passive/racial/golden_eyes), Instinct (Lupine) (/obj/skill/passive/racial/instinct), Kick (/obj/skill/kick), Skip (/obj/skill/skip), Limit Potential (/obj/skill/toggle/limit_potential), Flee (/obj/skill/flee), End Turn (/obj/skill/end_turn), Leave Battle (/obj/skill/leave_battle)
System: Debug: get_all_actions_new: list was this - Movement (/obj/skill/move), Attack (/obj/skill/fe_attack), Multifront (/obj/skill/fe_attack/multifront), Capture (/obj/skill/capture), War Cry (/obj/skill/war_cry), Couloir (/obj/skill/couloir), Sillcut (/obj/skill/sillcut), Lance de Lion (/obj/skill/lance_de_lion), Cyclone Spear (/obj/skill/cyclone_spear), Falcon Strike (/obj/skill/falcon_strike), Rebound (/obj/skill/sk_rebound), Ether Invitation (/obj/skill/sk_ether_invite), Haunting (/obj/skill/sk_haunting), Gravestone (/obj/skill/gravestone), Painproof (/obj/skill/painproof), Burn Away (/obj/skill/burn_away), Dive Down (/obj/skill/dive_down), Lift Off (/obj/skill/spell/lift_off), Eviter (/obj/skill/toggle/eviter), (null), Guard (/obj/skill/fe_guard), Golden Eyes (/obj/skill/passive/racial/golden_eyes), Instinct (Lupine) (/obj/skill/passive/racial/instinct), Kick (/obj/skill/kick), Skip (/obj/skill/skip), Limit Potential (/obj/skill/toggle/limit_potential), Flee (/obj/skill/flee), End Turn (/obj/skill/end_turn), Leave Battle (/obj/skill/leave_battle)
System: Debug: Total Power for Doomed Spear / Doomed Spear was 176.5.
System: Debug: Before Use Skill called. Grave Digger, Doomed Spear, Attack, 1
System: Debug: Attack type: /obj/skill/fe_attack. attack_nums:
System: Debug: Total Power for Doomed Spear / Doomed Spear was 176.5.
Doomed Spear attacks Grave Digger with Doomed Spear!
Eviter! But Grave Digger parries the attack!
Grave Digger takes 40 Pierce physical damage.
System: * Initial Damage: 177.5 Pierce Physical, flags: , sk: null, wep: Doomed Spear / /obj/items/equip/weapon/spears/fellgrant_drinker * play_atk_anim was 1. * 43 Evade VS 231 Hit. (Damage Hit Mod was 0) *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 64 Critical VS 49 Critical Evade. (177.5) * spec_flat_reduc was 0. (177.5) * amp_multi was 1.05. (186.375) * reduc_multi was 25.1247. (46.8261); MAG DEF, 47.106 PHYS DEF, 95 REDUC * elem_reduc was 10. (42.1435) * armor was allowed. armor_reduc was 2. (40.1435) * Damage caps applied. (40.1435) * Damage shields applied. (40.1435) * Final damage was: 40.
Grave Digger attacks Doomed Spear with Shovel!
System: Debug: Mercalan Mist Bonus Evade: 0
System: Debug: Eviter: Starting check. user=Doomed Spear, atkr=Grave Digger, W=Shovel, S=null
System: Debug: Eviter: Chance of 26 was not successful.
Critical Hit! Doomed Spear takes 39 Pierce physical damage.
Status Infliction: 150.72 VS Status Resistance: 27
Doomed Spear was inflicted with Status Resistance Lowered!
System: * Initial Damage: 55.75 Pierce Physical, flags: counter, sk: null, wep: Shovel / /obj/items/equip/weapon/spears/deadly_smile * play_atk_anim was 1. * 11 Evade VS 229 Hit. (Damage Hit Mod was 0) *2 Roll(s) Remaining. This one was a hit. *1 Roll(s) Remaining. This one was a hit. * Critical check: 88 Critical VS 30 Critical Evade. (55.75) * Critical hit multi was 135. (75.2625) * spec_flat_reduc was 0. (75.2625) * amp_multi was 1.05. (79.0256) * reduc_multi was 83.885. (66.2906); MAG DEF, 11.7 PHYS DEF, 95 REDUC * elem_reduc was 0. (66.2906) * armor was allowed. armor_reduc was 27. (39.2906) * Damage caps applied. (39.2906) * Damage shields applied. (39.2906) * Final damage was: 39.
Grave Digger recovered 2 FP.
System: * basic_attack(atk:Grave Digger,def:Doomed Spear,W:Shovel,dmg_mod:0,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:50,counter:1,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 50. * crit_multi was 135. crit_dmg_flat was 0. attack_num was 1.
Doomed Spear recovered 1 FP.
Doomed Spear recovered 5 FP.
Doomed Spear recovered 9 HP.
System: * basic_attack(atk:Doomed Spear,def:Grave Digger,W:Doomed Spear,dmg_mod:1,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 100. atk_bonus was 0. dmg_scale was 0. * crit_multi was 157. crit_dmg_flat was 0. attack_num was 1.
System: Debug: 0&&1
System: Debug: get_all_actions_new: list was this - Movement (/obj/skill/move), Attack (/obj/skill/fe_attack), Multifront (/obj/skill/fe_attack/multifront), Capture (/obj/skill/capture), War Cry (/obj/skill/war_cry), Couloir (/obj/skill/couloir), Sillcut (/obj/skill/sillcut), Lance de Lion (/obj/skill/lance_de_lion), Cyclone Spear (/obj/skill/cyclone_spear), Falcon Strike (/obj/skill/falcon_strike), Rebound (/obj/skill/sk_rebound), Ether Invitation (/obj/skill/sk_ether_invite), Haunting (/obj/skill/sk_haunting), Gravestone (/obj/skill/gravestone), Painproof (/obj/skill/painproof), Burn Away (/obj/skill/burn_away), Dive Down (/obj/skill/dive_down), Lift Off (/obj/skill/spell/lift_off), Eviter (/obj/skill/toggle/eviter), (null), Guard (/obj/skill/fe_guard), Golden Eyes (/obj/skill/passive/racial/golden_eyes), Instinct (Lupine) (/obj/skill/passive/racial/instinct), Kick (/obj/skill/kick), Skip (/obj/skill/skip), Limit Potential (/obj/skill/toggle/limit_potential), Flee (/obj/skill/flee), End Turn (/obj/skill/end_turn), Leave Battle (/obj/skill/leave_battle)
Grave Digger's turn.
System: Debug: get_all_actions_new: list was this - Movement (/obj/skill/move), Attack (/obj/skill/fe_attack), Multifront (/obj/skill/fe_attack/multifront), Capture (/obj/skill/capture), War Cry (/obj/skill/war_cry), Couloir (/obj/skill/couloir), Sillcut (/obj/skill/sillcut), Lance de Lion (/obj/skill/lance_de_lion), Cyclone Spear (/obj/skill/cyclone_spear), Falcon Strike (/obj/skill/falcon_strike), Rebound (/obj/skill/sk_rebound), Ether Invitation (/obj/skill/sk_ether_invite), Haunting (/obj/skill/sk_haunting), Gravestone (/obj/skill/gravestone), Painproof (/obj/skill/painproof), Burn Away (/obj/skill/burn_away), Dive Down (/obj/skill/dive_down), Lift Off (/obj/skill/spell/lift_off), Eviter (/obj/skill/toggle/eviter), (null), Guard (/obj/skill/fe_guard), Golden Eyes (/obj/skill/passive/racial/golden_eyes), Instinct (Lupine) (/obj/skill/passive/racial/instinct), Kick (/obj/skill/kick), Skip (/obj/skill/skip), Limit Potential (/obj/skill/toggle/limit_potential), Flee (/obj/skill/flee), End Turn (/obj/skill/end_turn), Leave Battle (/obj/skill/leave_battle)
System: Debug: get_all_actions_new: list was this - Movement (/obj/skill/move), Attack (/obj/skill/fe_attack), Multifront (/obj/skill/fe_attack/multifront), Capture (/obj/skill/capture), War Cry (/obj/skill/war_cry), Couloir (/obj/skill/couloir), Sillcut (/obj/skill/sillcut), Lance de Lion (/obj/skill/lance_de_lion), Cyclone Spear (/obj/skill/cyclone_spear), Falcon Strike (/obj/skill/falcon_strike), Rebound (/obj/skill/sk_rebound), Ether Invitation (/obj/skill/sk_ether_invite), Haunting (/obj/skill/sk_haunting), Gravestone (/obj/skill/gravestone), Painproof (/obj/skill/painproof), Burn Away (/obj/skill/burn_away), Dive Down (/obj/skill/dive_down), Lift Off (/obj/skill/spell/lift_off), Eviter (/obj/skill/toggle/eviter), (null), Guard (/obj/skill/fe_guard), Golden Eyes (/obj/skill/passive/racial/golden_eyes), Instinct (Lupine) (/obj/skill/passive/racial/instinct), Kick (/obj/skill/kick), Skip (/obj/skill/skip), Limit Potential (/obj/skill/toggle/limit_potential), Flee (/obj/skill/flee), End Turn (/obj/skill/end_turn), Leave Battle (/obj/skill/leave_battle)