[Collector]

Parasitic does not restore durability on a critical hit as intended. The effect either doesn't function at all, or the weapon's durability doesn't change.

Here's a debug dump from testing. Weapon used was a Parasitic Akuijin with dragon remains material. Basic 'attack' command was used for testing. The weapon's durability decreased as normal in this specific case.


System: Debug: Total Power for Nibosshi / Nibosshi was 132.
 Severed Thread attacks Salamander with Nibosshi!
 Critical Hit! Salamander takes 163 Slash physical damage.
 Status Infliction: 119.88 VS Status Resistance: 55
 Salamander was inflicted with Status Resistance Lowered!

System: * Initial Damage: 155.25 Slash Physical, flags: , sk: null, wep: Nibosshi / /obj/items/equip/weapon/swords/akuijin * play_atk_anim was 1. * 99 Evade VS 211 Hit. (Damage Hit Mod was 0) *2 Roll(s) Remaining. This one was a hit. GLANCE_CHECK_FIRST was enabled and the first hit roll was successful, so no glancing. * Critical check: 131 Critical VS 53 Critical Evade. (155.25) * Critical hit multi was 119. Flat critical damage bonus was 0. (184.748) * spec_flat_reduc was 0. (184.748) * amp_multi was 1. (184.748) * reduc_multi was 92.8. (171.446); MAG DEF, 7.2 PHYS DEF, 100 REDUC * elem_reduc was 0. (171.446) * armor was allowed. armor_reduc was 8. (163.446) * Damage caps applied. (163.446) * Damage shields applied. (163.446) * Final damage was: 163.

 Severed Thread recovered 2 FP.[img]file:///C:/Users/seven/Documents/BYOND/cache/tmp8400/battle_msg.png[/img] Salamander takes 35 Darkness magical damage.
System: * Initial Damage: 39 Darkness Magic, flags: no_armor, bonus, magic, sk: null, wep: Nibosshi / /obj/items/equip/weapon/swords/akuijin * play_atk_anim was . * Critical check: Defender was critical immune or crit_multi was 0. (39) * spec_flat_reduc was 0. (39) * amp_multi was 1. (39) * reduc_multi was 92.8. (36.192); 7.2 MAG DEF, PHYS DEF, 100 REDUC * elem_reduc was 2. (35.4682) * Damage caps applied. (35.4682) * Damage shields applied. (35.4682) * Final damage was: 35.

System: * basic_attack(atk:Severed Thread,def:Salamander,W:Nibosshi,dmg_mod:1,hit_mod:0,crit_mod:0,crit_dmg_mod:0,spec_flags:,auto_hit:0,dmg_scale:0,counter:0,magic_atk:0,ignore_onhit:0,dtype_rep:,retal_ok:1,auto_crit:0,fatal:1,ignore_closes:0,dmg_scale_post:,attack_num:1) * atk_multi was 115. atk_bonus was 2. dmg_scale was 0. * crit_multi was 119. crit_dmg_flat was 0. attack_num was 1.

[Neus]

This should be corrected in 2.64.